Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2686063003: [remote suggestions] Attach the fetch time to RemoteSnippets, ContentSnippets and SnippetArticle (Closed)
Patch Set: Update RemoteSuggestionTest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 716439a01c45e81f683c79af193d308c727600a5..d086f8912a40af03407ebb1afdb93c2e44490a9e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -151,7 +151,8 @@ public class SnippetsBridge implements SuggestionsSource, SuggestionsMetricsRepo
assert mNativeSnippetsBridge != 0;
nativeOnSuggestionShown(mNativeSnippetsBridge, suggestion.getGlobalRank(),
suggestion.mCategory, suggestion.getPerSectionRank(),
- suggestion.mPublishTimestampMilliseconds, suggestion.mScore);
+ suggestion.mPublishTimestampMilliseconds, suggestion.mScore,
+ suggestion.mFetchTimestampMilliseconds);
}
@Override
@@ -259,10 +260,10 @@ public class SnippetsBridge implements SuggestionsSource, SuggestionsMetricsRepo
@CalledByNative
private static SnippetArticle addSuggestion(List<SnippetArticle> suggestions, int category,
String id, String title, String publisher, String previewText, String url,
- long timestamp, float score) {
+ long timestamp, float score, long fetchTime) {
int position = suggestions.size();
suggestions.add(new SnippetArticle(
- category, id, title, publisher, previewText, url, timestamp, score));
+ category, id, title, publisher, previewText, url, timestamp, score, fetchTime));
return suggestions.get(position);
}
@@ -340,7 +341,8 @@ public class SnippetsBridge implements SuggestionsSource, SuggestionsMetricsRepo
private native void nativeOnPageShown(
long nativeNTPSnippetsBridge, int[] categories, int[] suggestionsPerCategory);
private native void nativeOnSuggestionShown(long nativeNTPSnippetsBridge, int globalPosition,
- int category, int positionInCategory, long publishTimestampMs, float score);
+ int category, int positionInCategory, long publishTimestampMs, float score,
+ long fetchTimestampMs);
private native void nativeOnSuggestionOpened(long nativeNTPSnippetsBridge, int globalPosition,
int category, int categoryIndex, int positionInCategory, long publishTimestampMs,
float score, int windowOpenDisposition);

Powered by Google App Engine
This is Rietveld 408576698