Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: components/ntp_snippets/remote/json_request_unittest.cc

Issue 2686063003: [remote suggestions] Attach the fetch time to RemoteSnippets, ContentSnippets and SnippetArticle (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/remote/json_request.h" 5 #include "components/ntp_snippets/remote/json_request.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 class JsonRequestTest : public testing::Test { 60 class JsonRequestTest : public testing::Test {
61 public: 61 public:
62 JsonRequestTest() 62 JsonRequestTest()
63 : params_manager_( 63 : params_manager_(
64 ntp_snippets::kStudyName, 64 ntp_snippets::kStudyName,
65 {{"send_top_languages", "true"}, {"send_user_class", "true"}}, 65 {{"send_top_languages", "true"}, {"send_user_class", "true"}},
66 {ntp_snippets::kArticleSuggestionsFeature.name}), 66 {ntp_snippets::kArticleSuggestionsFeature.name}),
67 pref_service_(base::MakeUnique<TestingPrefServiceSimple>()), 67 pref_service_(base::MakeUnique<TestingPrefServiceSimple>()),
68 mock_task_runner_(new base::TestMockTimeTaskRunner()), 68 mock_task_runner_(new base::TestMockTimeTaskRunner()),
69 tick_clock_(mock_task_runner_->GetMockTickClock()), 69 clock_(mock_task_runner_->GetMockClock()),
70 request_context_getter_( 70 request_context_getter_(
71 new net::TestURLRequestContextGetter(mock_task_runner_.get())) { 71 new net::TestURLRequestContextGetter(mock_task_runner_.get())) {
72 translate::LanguageModel::RegisterProfilePrefs(pref_service_->registry()); 72 translate::LanguageModel::RegisterProfilePrefs(pref_service_->registry());
73 } 73 }
74 74
75 std::unique_ptr<translate::LanguageModel> MakeLanguageModel( 75 std::unique_ptr<translate::LanguageModel> MakeLanguageModel(
76 const std::set<std::string>& codes) { 76 const std::set<std::string>& codes) {
77 std::unique_ptr<translate::LanguageModel> language_model = 77 std::unique_ptr<translate::LanguageModel> language_model =
78 base::MakeUnique<translate::LanguageModel>(pref_service_.get()); 78 base::MakeUnique<translate::LanguageModel>(pref_service_.get());
79 // There must be at least 10 visits before the top languages are defined. 79 // There must be at least 10 visits before the top languages are defined.
80 for (int i = 0; i < 10; i++) { 80 for (int i = 0; i < 10; i++) {
81 for (const std::string& code : codes) { 81 for (const std::string& code : codes) {
82 language_model->OnPageVisited(code); 82 language_model->OnPageVisited(code);
83 } 83 }
84 } 84 }
85 return language_model; 85 return language_model;
86 } 86 }
87 87
88 JsonRequest::Builder CreateMinimalBuilder() { 88 JsonRequest::Builder CreateMinimalBuilder() {
89 JsonRequest::Builder builder; 89 JsonRequest::Builder builder;
90 builder.SetUrl(GURL("http://valid-url.test")) 90 builder.SetUrl(GURL("http://valid-url.test"))
91 .SetTickClock(tick_clock_.get()) 91 .SetClock(clock_.get())
92 .SetUrlRequestContextGetter(request_context_getter_.get()); 92 .SetUrlRequestContextGetter(request_context_getter_.get());
93 return builder; 93 return builder;
94 } 94 }
95 95
96 private: 96 private:
97 variations::testing::VariationParamsManager params_manager_; 97 variations::testing::VariationParamsManager params_manager_;
98 std::unique_ptr<TestingPrefServiceSimple> pref_service_; 98 std::unique_ptr<TestingPrefServiceSimple> pref_service_;
99 scoped_refptr<base::TestMockTimeTaskRunner> mock_task_runner_; 99 scoped_refptr<base::TestMockTimeTaskRunner> mock_task_runner_;
100 std::unique_ptr<base::TickClock> tick_clock_; 100 std::unique_ptr<base::Clock> clock_;
101 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; 101 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
102 net::TestURLFetcherFactory fetcher_factory_; 102 net::TestURLFetcherFactory fetcher_factory_;
103 103
104 DISALLOW_COPY_AND_ASSIGN(JsonRequestTest); 104 DISALLOW_COPY_AND_ASSIGN(JsonRequestTest);
105 }; 105 };
106 106
107 TEST_F(JsonRequestTest, BuildRequestAuthenticated) { 107 TEST_F(JsonRequestTest, BuildRequestAuthenticated) {
108 JsonRequest::Builder builder = CreateMinimalBuilder(); 108 JsonRequest::Builder builder = CreateMinimalBuilder();
109 RequestParams params; 109 RequestParams params;
110 params.excluded_ids = {"1234567890"}; 110 params.excluded_ids = {"1234567890"};
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 " \"topLanguages\": [{" 314 " \"topLanguages\": [{"
315 " \"language\" : \"en\"," 315 " \"language\" : \"en\","
316 " \"frequency\" : 1.0" 316 " \"frequency\" : 1.0"
317 " }]" 317 " }]"
318 "}")); 318 "}"));
319 } 319 }
320 320
321 } // namespace internal 321 } // namespace internal
322 322
323 } // namespace ntp_snippets 323 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/remote/json_request.cc ('k') | components/ntp_snippets/remote/proto/ntp_snippets.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698