[remote suggestions] Attach the fetch time to RemoteSnippets, ContentSnippets and SnippetArticle

components/ntp_snippets/remote/remote_suggestion.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTION_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTION_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 20 matching lines @@
  public:
   using PtrVector = std::vector<std::unique_ptr<RemoteSuggestion>>;
 
   ~RemoteSuggestion();
 
   // Creates a RemoteSuggestion from a dictionary, as returned by Chrome Reader.
   // Returns a null pointer if the dictionary doesn't correspond to a valid
   // suggestion. The keys in the dictionary are expected to be the same as the
   // property name, with exceptions documented in the property comment.
   static std::unique_ptr<RemoteSuggestion> CreateFromChromeReaderDictionary(
-      const base::DictionaryValue& dict);
+      const base::DictionaryValue& dict,
+      const base::Time& fetch_time);
 
   // Creates a RemoteSuggestion from a dictionary, as returned by Chrome Content
   // Suggestions. Returns a null pointer if the dictionary doesn't correspond to
   // a valid suggestion. Maps field names to Chrome Reader field names.
   static std::unique_ptr<RemoteSuggestion>
   CreateFromContentSuggestionsDictionary(const base::DictionaryValue& dict,
-                                         int remote_category_id);
+                                         int remote_category_id,
+                                         const base::Time& fetch_time);
 
   // Creates an RemoteSuggestion from a protocol buffer. Returns a null pointer
   // if the protocol buffer doesn't correspond to a valid suggestion.
   static std::unique_ptr<RemoteSuggestion> CreateFromProto(
       const SnippetProto& proto);
 
   // TODO(treib): Make tests use the public interface and remove this.
   static std::unique_ptr<RemoteSuggestion> CreateForTesting(
       const std::string& id,
       int remote_category_id,
       const GURL& url,
       const std::string& publisher_name,
       const GURL& amp_url);
 
   // Creates a protocol buffer corresponding to this suggestion, for persisting.
   SnippetProto ToProto() const;
 
+  // TODO(markusheintz): Move this method to the ContentSuggestion class.

[Marc Treib, 2017/02/10 16:16:56]

No, this belongs here IMO. The general ContentSuggestion class shouldn't know
about the provider-specific suggestion types.

[markusheintz_, 2017/02/13 09:59:55]

I'll remove the TODO. Not feeling strongly about it.

   // Coverts to general content suggestion form
   ContentSuggestion ToContentSuggestion(Category category) const;
 
   // Returns all ids of the suggestion.
   const std::vector<std::string>& GetAllIDs() const { return ids_; }
 
   // The unique, primary ID for identifying the suggestion.
   const std::string& id() const { return ids_.front(); }
 
   // Title of the suggestion.
@@ skipping 37 matching lines @@
   bool should_notify() const { return should_notify_; }
   base::Time notification_deadline() const { return notification_deadline_; }
 
   bool is_dismissed() const { return is_dismissed_; }
   void set_dismissed(bool dismissed) { is_dismissed_ = dismissed; }
 
   // The ID of the remote category this suggestion belongs to, for use with
   // CategoryFactory::FromRemoteCategory.
   int remote_category_id() const { return remote_category_id_; }
 
+  base::Time fetch_time() const { return fetch_time_; }
+
   // Public for testing.
   static base::Time TimeFromJsonString(const std::string& timestamp_str);
   static std::string TimeToJsonString(const base::Time& time);
 
  private:
   RemoteSuggestion(const std::vector<std::string>& ids, int remote_category_id);
 
   // base::MakeUnique doesn't work if the ctor is private.
   static std::unique_ptr<RemoteSuggestion> MakeUnique(
       const std::vector<std::string>& ids,
@@ skipping 12 matching lines @@
   std::string snippet_;
   base::Time publish_date_;
   base::Time expiry_date_;
   float score_;
   bool is_dismissed_;
   int remote_category_id_;
 
   bool should_notify_;
   base::Time notification_deadline_;
 
+  // The time when the remote suggestions was fetched from the server.
+  base::Time fetch_time_;
+
   DISALLOW_COPY_AND_ASSIGN(RemoteSuggestion);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTION_H_