[not for review] Web MIDI: new backend to support dynamic instantiation on Windows

Web MIDI: new backend to support dynamic instantiation on Windows

This patch implements new backend that supports dynamic instantiation
on Windows.

BUG=497573, 617086, 672793

[Takashi Toyoshima, 2017-02-13 16:32:26]

Description was changed from

==========
wip

BUG=
==========

to

==========
Web MIDI: new backend to support dynamic instantiation on Windows

This patch implements new backend that supports dynamic instantiation
on Windows.

BUG=497573, 617086, 672793
==========

[Takashi Toyoshima, 2017-02-13 16:32:26]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2017-02-13 16:45:04]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 16:45:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-02-13 16:45:26]

ptal ps7

[commit-bot: I haz the power, 2017-02-13 16:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 16:53:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Takashi Toyoshima, 2017-02-13 16:58:57]

hum... dry run reports presubmit check error unexpectedly. please ignore this
error that may happen due to infra issue.

[DaleCurtis, 2017-02-13 19:12:51]

** Presubmit ERRORS **
base::LazyInstance is deprecated; use a thread safe static.
  media/midi/midi_manager_win2.cc:63 \
  media/midi/midi_manager_win2.cc:69

Presubmit checks took 3.0s to calculate.

[Takashi Toyoshima, 2017-02-16 04:44:06]

Dale: Oh, thanks. That makes sense. I will fix them in the next patch set.

[Takashi Toyoshima, 2017-02-17 05:05:26]

yhirano: shall I split this into smaller CLs?
Probably, I could split open/close/send/receive functionalities into the next
CL.
This is not urgent, but want to complete it by the next branch-cut.

FYI, two small changes will follow this for moving some API calls outside
callback, decoding USB vendor/product IDs.

[yhirano, 2017-02-17 05:53:30]

On 2017/02/17 05:05:26, Takashi Toyoshima wrote:
> yhirano: shall I split this into smaller CLs?
> Probably, I could split open/close/send/receive functionalities into the next
> CL.
> This is not urgent, but want to complete it by the next branch-cut.
> 
> FYI, two small changes will follow this for moving some API calls outside
> callback, decoding USB vendor/product IDs.

Awesome!

Before splitting the CL I would say I'm unhappy with the class name. Could you
give a better name?

[Takashi Toyoshima, 2017-02-17 06:01:34]

How about ExperimentalMidiManagerWin?

Other candidates:
 - NewMidiManagerWin
 - MidiManagerV2Win

FYI, I will remove the old MidiManagerWin once this new version hits the stable
(unless we see a serious issue that can not be fixed on canary-beta).

[yhirano, 2017-02-17 06:45:00]

On 2017/02/17 06:01:34, Takashi Toyoshima wrote:
> How about ExperimentalMidiManagerWin?
> 
> Other candidates:
>  - NewMidiManagerWin
>  - MidiManagerV2Win
> 
> FYI, I will remove the old MidiManagerWin once this new version hits the
stable
> (unless we see a serious issue that can not be fixed on canary-beta).

We already have a new midi manager for windows. It's called MidiManagerWinrt.

DynamicallyInitializedMidiManagerWin? Is it too long?

[Takashi Toyoshima, 2017-02-17 06:55:36]

Aha. I agreed that all words like experimental, new, v2 are vague here :)

[Takashi Toyoshima, 2017-02-17 09:27:03]

I will keep this change as is so that we can reference this when it is needed.
The first subset of this patch is uploaded here.
https://codereview.chromium.org/2704643002/