Block empty space selection

When user do longpress between text, user can select empty space selection. it's no need for user.

BUG=368987

[kth81.kim1, 2014-05-02 10:16:28]

PTAL

[jianli, 2014-05-05 06:01:45]

Please find some other reviewer based on the change history of the file.


On Sun, May 4, 2014 at 8:28 PM, <kth81.kim@samsung.com> wrote:

> https://codereview.chromium.org/268593009/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[kth81.kim1, 2014-05-05 06:37:13]

PTAL

[Yuta Kitamura, 2014-05-07 11:09:08]

I couldn't understand what the patch tried to do.

Please provide enough information in the change description
so that the reviewers can understand "why" and "how" of
the patch.

Also, please add tests.

https://codereview.chromium.org/268593009/diff/1/Source/core/editing/VisibleS...
File Source/core/editing/VisibleSelection.cpp (right):

https://codereview.chromium.org/268593009/diff/1/Source/core/editing/VisibleS...
Source/core/editing/VisibleSelection.cpp:364: }
It's totally unclear to me why |start| and |end| need to be
updated in this fashion.

[yosin_UTC9, 2014-05-08 03:53:29]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-05-08 03:54:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kth81.kim@samsung.com/268593009/1

[commit-bot: I haz the power, 2014-05-08 03:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 03:54:06]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[yosin_UTC9, 2014-05-08 03:55:28]

It seems better place is |EventHandler::selectClosestWordFromHitTestResult|,
rather than
|VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity| for:
 - minimize affects of behavior change
 - original issue is behavior of long press(touch device) and
double-click(desktop)

[yosin_UTC9, 2014-05-08 04:01:01]

Please add LayoutTest for this behavior change.
See LayoutTests/fast/events/touch/gesture/gesture-dblclick.html

[kth81.kim1, 2014-05-09 04:44:38]

On 2014/05/08 04:01:01, Yosi OOF til May 12 wrote:
> Please add LayoutTest for this behavior change.
> See LayoutTests/fast/events/touch/gesture/gesture-dblclick.html

I will add LayoutTest and re-upload it.
In additional, user sometimes can select empty space between text.
and then when user do cut/copy, it showed empty clipboard.
I think it's no need for user. so we have to block empty space selection.

[kth81.kim1, 2014-05-09 04:45:08]

The CQ bit was checked by kth81.kim@samsung.com

[kth81.kim1, 2014-05-09 04:45:10]

The CQ bit was unchecked by kth81.kim@samsung.com