Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 268593002: Move existing Mojo JS <--> CPP tests out of webui test harness. (Closed)

Created:
6 years, 7 months ago by Tom Sepez
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Move existing Mojo JS <--> CPP tests out of webui test harness. The mojo webui test in content_browsertests was not the proper place to perform bindings-related fuzzing (though it was initially convenient). As a first step, move the existing tests to the new "framework" sky added in https://src.chromium.org/viewvc/chrome?revision=267208&view=revision This also restores the webui code to something near its original purpose, although I've kept a few of the hooks that may be useful as real webui tests are added. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267703

Patch Set 1 #

Patch Set 2 : Remove unused header include. #

Total comments: 4

Patch Set 3 : Remove global vars, change directory for .mojom file. #

Patch Set 4 : Fix JS busted when I alphebetized dependency list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -283 lines) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 6 chunks +0 lines, -152 lines 0 comments Download
M content/test/data/web_ui_mojo.js View 2 chunks +1 line, -28 lines 0 comments Download
M content/test/data/web_ui_test_mojo_bindings.mojom View 1 chunk +0 lines, -23 lines 0 comments Download
A + mojo/apps/js/test/js_to_cpp.mojom View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 2 2 chunks +174 lines, -63 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.js View 1 2 3 1 chunk +43 lines, -12 lines 0 comments Download
M mojo/mojo_apps.gypi View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Sepez
Sky, please take a look. Thanks heaps.
6 years, 7 months ago (2014-04-30 23:34:27 UTC) #1
sky
https://codereview.chromium.org/268593002/diff/20001/mojo/apps/js/test/js_to_cpp_unittest.cc File mojo/apps/js/test/js_to_cpp_unittest.cc (right): https://codereview.chromium.org/268593002/diff/20001/mojo/apps/js/test/js_to_cpp_unittest.cc#newcode27 mojo/apps/js/test/js_to_cpp_unittest.cc:27: int message_count = 0; Can you scope these to ...
6 years, 7 months ago (2014-05-01 03:20:38 UTC) #2
Tom Sepez
https://codereview.chromium.org/268593002/diff/20001/mojo/apps/js/test/js_to_cpp_unittest.cc File mojo/apps/js/test/js_to_cpp_unittest.cc (right): https://codereview.chromium.org/268593002/diff/20001/mojo/apps/js/test/js_to_cpp_unittest.cc#newcode27 mojo/apps/js/test/js_to_cpp_unittest.cc:27: int message_count = 0; On 2014/05/01 03:20:38, sky wrote: ...
6 years, 7 months ago (2014-05-01 17:48:26 UTC) #3
Tom Sepez
On 2014/05/01 17:48:26, Tom Sepez wrote: > https://codereview.chromium.org/268593002/diff/20001/mojo/apps/js/test/js_to_cpp_unittest.cc > File mojo/apps/js/test/js_to_cpp_unittest.cc (right): > > https://codereview.chromium.org/268593002/diff/20001/mojo/apps/js/test/js_to_cpp_unittest.cc#newcode27 ...
6 years, 7 months ago (2014-05-01 17:51:24 UTC) #4
Tom Sepez
Sky, please review. Thanks.
6 years, 7 months ago (2014-05-01 18:11:35 UTC) #5
sky
LGTM - ya, moving to different directory is what I meant. Sorry for not being ...
6 years, 7 months ago (2014-05-01 18:15:11 UTC) #6
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-01 19:39:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/268593002/60001
6 years, 7 months ago (2014-05-01 19:40:29 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 00:49:07 UTC) #9
Message was sent while issue was closed.
Change committed as 267703

Powered by Google App Engine
This is Rietveld 408576698