Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2685883005: Add tests to vaildate the analysis server's integration test coverage. (Closed)

Created:
3 years, 10 months ago by devoncarew
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests to vaildate the analysis server's integration test coverage. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/bc9cadac04c3012b2e1538e2666f8d89a6f77f83

Patch Set 1 #

Patch Set 2 : updated to use package:path #

Patch Set 3 : organize directives #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -0 lines) Patch
A pkg/analysis_server/test/integration/coverage.md View 1 chunk +51 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/coverage_test.dart View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
devoncarew
This adds tests to validate and track the analysis server's integration test coverage. It parses ...
3 years, 10 months ago (2017-02-09 16:08:37 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-09 16:14:57 UTC) #3
devoncarew
Thanks for the review! (updated to use package:path)
3 years, 10 months ago (2017-02-09 16:38:57 UTC) #4
devoncarew
3 years, 10 months ago (2017-02-09 22:26:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bc9cadac04c3012b2e1538e2666f8d89a6f77f83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698