Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2685883004: Explicitly invalidate LayoutView when overflow is recalculated. (Closed)
Patch Set: Conditionally invalidate based on visualViewportSuppliesScrollbars Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index efc80fa5c09c38874f7c3119b3de6e9c9b0cb129..c2a02aed88c52165dc5feee7f88f1bebb8f35680 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -830,6 +830,12 @@ void FrameView::recalcOverflowAfterStyleChange() {
if (needsLayout())
return;
+ // If the visualViewport supplies scrollbars, we won't get a paint
+ // invalidation from computeScrollbarExistence so we need to force one
+ // TODO(bokan): We should avoid computeScrollbarExistence otherwise.
+ if (visualViewportSuppliesScrollbars())
+ layoutViewItem.setMayNeedPaintInvalidation();
+
// TODO(pdr): This should be refactored to just block scrollbar updates as
// we are not in a scrollbar update here and m_inUpdateScrollbars has other
// side effects. This scope is only for preventing a synchronous layout from
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698