Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 268583002: Access parameter data in Annotations, as well as fixed export visibility (Closed)

Created:
6 years, 7 months ago by Emily Fortuna
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Access parameter data in Annotations, as well as fixed export visibility calculation. BUG= R=alanknight@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=35768

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -59 lines) Patch
M pkg/docgen/lib/docgen.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/docgen/lib/src/generator.dart View 3 chunks +8 lines, -10 lines 0 comments Download
M pkg/docgen/lib/src/library_helpers.dart View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/docgen/lib/src/models/annotation.dart View 1 2 1 chunk +87 lines, -29 lines 0 comments Download
M pkg/docgen/lib/src/models/model_helpers.dart View 1 3 chunks +13 lines, -9 lines 0 comments Download
A + pkg/docgen/test/multi_library_code/lib/test_lib2.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/docgen/test/multi_library_code/lib/test_lib2_bar.dart View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/docgen/test/multi_library_code/lib/test_lib2_foo.dart View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/docgen/test/multi_library_test.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Emily Fortuna
This is a fix for the Angular issue: https://code.google.com/p/dart/issues/detail?id=17982 Peter, you need only look at ...
6 years, 7 months ago (2014-04-30 23:24:42 UTC) #1
Alan Knight
LGTM.
6 years, 7 months ago (2014-04-30 23:47:13 UTC) #2
ahe
I'd be more comfortable if Johnni or Florian would review this.
6 years, 7 months ago (2014-05-01 09:01:48 UTC) #3
Emily Fortuna
bump Johnni or Florian?
6 years, 7 months ago (2014-05-01 18:20:42 UTC) #4
Johnni Winther
On 2014/05/01 18:20:42, Emily Fortuna wrote: > bump Johnni or Florian? Florian is on vacation ...
6 years, 7 months ago (2014-05-01 18:45:27 UTC) #5
kevmoo
DBC Tests? I ran this through my pretty formatted output. I noticed some changes of ...
6 years, 7 months ago (2014-05-02 00:21:22 UTC) #6
Johnni Winther
lgtm
6 years, 7 months ago (2014-05-02 05:55:35 UTC) #7
Emily Fortuna
6 years, 7 months ago (2014-05-05 21:31:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r35768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698