ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm - Issue 2685823002: [ios clean] ToolsMenu UI changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm

Issue 2685823002: [ios clean] ToolsMenu UI changes (Closed)

Patch Set: Tools Menu UI Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm

diff --git a/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm b/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm

index ebba79871565b162ae2b64ee7f9cde5e6ccfa2a6..e875bff3dd25ac55b861d3e7fcf311b0c9d6b9e3 100644

--- a/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm

+++ b/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm

@@ -50,9 +50,10 @@

}

- (void)presentationTransitionWillBegin {

- self.presentedView.layer.borderWidth = 1.0;

- self.presentedView.layer.shadowRadius = 1.0;

- self.presentedView.layer.borderColor = [UIColor blackColor].CGColor;

+ self.presentedView.layer.shadowRadius = 5.0f;

+ [self.presentedView.layer setShadowOpacity:0.4f];

edchin 2017/02/11 00:00:25 nit: Make this line same as others. (dot vs. brack

sczs 2017/02/11 00:04:15 Done.

+ self.presentedView.layer.shadowOffset = CGSizeMake(0, 0);

edchin 2017/02/11 00:00:25 nit: Other floats here use the form 0.0f.

sczs 2017/02/11 00:04:15 Done.

+ self.presentedView.layer.cornerRadius = 2.0f;

self.dismissRecognizer =

[[UITapGestureRecognizer alloc] initWithTarget:self

« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/tools/BUILD.gn » ('j') | no next file with comments »