Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm

Issue 2685803002: Fixed title updating for back forward navigation. (Closed)
Patch Set: Stubbed title call Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_wk_navigation_states.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
diff --git a/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm b/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
index 61c44093c0ca5c99fed4017853655b0e83707f0a..5b3eb4f313dd1cec5a721b0da7c627aac0935673 100644
--- a/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
+++ b/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
@@ -31,14 +31,22 @@ TEST_F(CRWWKNavigationStatesTest, LastAddedNavigation) {
// navigation_1 is the only navigation and it is the latest.
[states_ setState:WKNavigationState::REQUESTED forNavigation:navigation1_];
EXPECT_EQ(navigation1_, [states_ lastAddedNavigation]);
+ EXPECT_EQ(WKNavigationState::REQUESTED, [states_ lastAddedNavigationState]);
// navigation_2 is added later and hence the latest.
[states_ setState:WKNavigationState::REQUESTED forNavigation:navigation2_];
EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]);
+ EXPECT_EQ(WKNavigationState::REQUESTED, [states_ lastAddedNavigationState]);
// Updating state for existing navigation does not make it the latest.
[states_ setState:WKNavigationState::STARTED forNavigation:navigation1_];
EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]);
+ EXPECT_EQ(WKNavigationState::REQUESTED, [states_ lastAddedNavigationState]);
+
+ // navigation_2 is still the latest.
+ [states_ setState:WKNavigationState::STARTED forNavigation:navigation2_];
+ EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]);
+ EXPECT_EQ(WKNavigationState::STARTED, [states_ lastAddedNavigationState]);
}
} // namespace web
« no previous file with comments | « ios/web/web_state/ui/crw_wk_navigation_states.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698