Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: runtime/lib/internal_patch.dart

Issue 2685783009: (Re)move methods from internal.Lists that are not used, or only used once. (Closed)
Patch Set: Don't be clever (doubles can be equal to ints) and change all occurrences. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/array.dart ('k') | runtime/lib/typed_data_patch.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 @patch List makeListFixedLength(List growableList) 5 @patch List makeListFixedLength(List growableList)
6 native "Internal_makeListFixedLength"; 6 native "Internal_makeListFixedLength";
7 7
8 @patch List makeFixedListUnmodifiable(List fixedLengthList) 8 @patch List makeFixedListUnmodifiable(List fixedLengthList)
9 native "Internal_makeFixedListUnmodifiable"; 9 native "Internal_makeFixedListUnmodifiable";
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 bool _inquireIs64Bit() native "Internal_inquireIs64Bit"; 37 bool _inquireIs64Bit() native "Internal_inquireIs64Bit";
38 38
39 bool _classRangeCheck(int cid, int lowerLimit, int upperLimit) { 39 bool _classRangeCheck(int cid, int lowerLimit, int upperLimit) {
40 return cid >= lowerLimit && cid <= upperLimit; 40 return cid >= lowerLimit && cid <= upperLimit;
41 } 41 }
42 42
43 bool _classRangeCheckNegative(int cid, int lowerLimit, int upperLimit) { 43 bool _classRangeCheckNegative(int cid, int lowerLimit, int upperLimit) {
44 return cid < lowerLimit || cid > upperLimit; 44 return cid < lowerLimit || cid > upperLimit;
45 } 45 }
46
47 // Utility class now only used by the VM.
48 class Lists {
49 static void copy(List src, int srcStart,
floitsch 2017/02/15 17:11:38 Nit: use full names. That said: I don't think this
Lasse Reichstein Nielsen 2017/02/17 11:25:20 Correct. I dare not touch it, since it seems to be
50 List dst, int dstStart, int count) {
51 if (srcStart < dstStart) {
52 for (int i = srcStart + count - 1, j = dstStart + count - 1;
53 i >= srcStart; i--, j--) {
54 dst[j] = src[i];
55 }
56 } else {
57 for (int i = srcStart, j = dstStart; i < srcStart + count; i++, j++) {
58 dst[j] = src[i];
59 }
60 }
61 }
62 }
OLDNEW
« no previous file with comments | « runtime/lib/array.dart ('k') | runtime/lib/typed_data_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698