Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2685783009: (Re)move methods from internal.Lists that are not used, or only used once. (Closed)

Created:
3 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move methods from internal.Lists that are not used, or only used once. Remove the class (actually move it to the VM-only dart:_internal patch, because the VM code depends on recognizing the Lists.copy method). R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/d26132d1197abb67ef761a76a61bcbb6e3e5d97e

Patch Set 1 #

Patch Set 2 : Don't be clever (doubles can be equal to ints) and change all occurrences. #

Total comments: 2

Patch Set 3 : Merge to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -100 lines) Patch
M runtime/lib/array.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/lib/typed_data_patch.dart View 1 1 chunk +18 lines, -3 lines 0 comments Download
M sdk/lib/internal/internal.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/internal/internal_sources.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/internal/lists.dart View 1 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-14 06:53:20 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/2685783009/diff/20001/runtime/lib/internal_patch.dart File runtime/lib/internal_patch.dart (right): https://codereview.chromium.org/2685783009/diff/20001/runtime/lib/internal_patch.dart#newcode49 runtime/lib/internal_patch.dart:49: static void copy(List src, int srcStart, Nit: use ...
3 years, 10 months ago (2017-02-15 17:11:38 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/2685783009/diff/20001/runtime/lib/internal_patch.dart File runtime/lib/internal_patch.dart (right): https://codereview.chromium.org/2685783009/diff/20001/runtime/lib/internal_patch.dart#newcode49 runtime/lib/internal_patch.dart:49: static void copy(List src, int srcStart, Correct. I dare ...
3 years, 10 months ago (2017-02-17 11:25:20 UTC) #5
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-17 11:25:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d26132d1197abb67ef761a76a61bcbb6e3e5d97e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698