Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2685783003: Fix access to returnTypeOf (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix access to returnTypeOf - a field does not have a return type. Committed: https://github.com/dart-lang/sdk/commit/20e2aa4f0ec622331e47f2cc5b86a18169f2df4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Johnni Winther
TBR
3 years, 10 months ago (2017-02-08 09:08:03 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 20e2aa4f0ec622331e47f2cc5b86a18169f2df4d (presubmit successful).
3 years, 10 months ago (2017-02-08 09:08:32 UTC) #4
Emily Fortuna
lgtm. Johnni, I'm still seeing the uri_example_test failing and deferred_regression_28678_test failing with this change patched ...
3 years, 10 months ago (2017-02-09 02:23:31 UTC) #5
Johnni Winther
On 2017/02/09 02:23:31, Emily Fortuna wrote: > lgtm. > > Johnni, I'm still seeing the ...
3 years, 10 months ago (2017-02-09 08:47:17 UTC) #6
Johnni Winther
On 2017/02/09 08:47:17, Johnni Winther wrote: > On 2017/02/09 02:23:31, Emily Fortuna wrote: > > ...
3 years, 10 months ago (2017-02-09 08:55:48 UTC) #7
Emily Fortuna
3 years, 10 months ago (2017-02-09 17:27:06 UTC) #8
Message was sent while issue was closed.
On 2017/02/09 08:55:48, Johnni Winther wrote:
> On 2017/02/09 08:47:17, Johnni Winther wrote:
> > On 2017/02/09 02:23:31, Emily Fortuna wrote:
> > > lgtm. 
> > > 
> > > Johnni, I'm still seeing the uri_example_test failing and
> > > deferred_regression_28678_test failing with this change patched in?
> > 
> > uri_example_test is a new test (added after my original CL) so it didn't
fail
> > (or succeed) before ;-)
> 
> On so was deferred_regression_28678_test:
> https://codereview.chromium.org/2683973002

ah, gotcha! Sorry about that! And thanks for the fixes!

Powered by Google App Engine
This is Rietveld 408576698