Fix findbugs warnings - make constants final.

Fix findbugs warnings - make constants final.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268012

[boliu, 2014-05-01 22:03:31]

The correct way to do this currently is use a template file then generate the
java and native files from the template at compile time. For example
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

Also I don't have owner powers here.

[vandebo (ex-Chrome), 2014-05-02 17:10:44]

+jam, +benm for OWNERS review

On 2014/05/01 22:03:31, boliu wrote:
> The correct way to do this currently is use a template file then generate the
> java and native files from the template at compile time. For example
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

Done.

> 
> Also I don't have owner powers here.

[benm (inactive), 2014-05-02 17:33:13]

android_webview lgtm

[jam, 2014-05-02 18:42:08]

On 2014/05/01 22:03:31, boliu wrote:
> The correct way to do this currently is use a template file then generate the
> java and native files from the template at compile time. 

at a very large cost in terms of readability and searchability...

i know we've done this in the past, but those have been large lists. i prefer
patchset 1 here

i wonder if instead of using this template stuff for android, we can have a
script that generates java files based on a header with a normal C++ enum
instead.


> For example
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...
> 
> Also I don't have owner powers here.

[vandebo (ex-Chrome), 2014-05-02 21:24:01]

On 2014/05/02 18:42:08, jam wrote:
> On 2014/05/01 22:03:31, boliu wrote:
> > The correct way to do this currently is use a template file then generate
the
> > java and native files from the template at compile time. 
> 
> at a very large cost in terms of readability and searchability...
> 
> i know we've done this in the past, but those have been large lists. i prefer
> patchset 1 here

Either should solve the findbugs issue, so just let me know which to do.  patch
set 1 isn't really any worse than what's already there.

[boliu, 2014-05-02 23:12:44]

On 2014/05/02 21:24:01, vandebo wrote:
> On 2014/05/02 18:42:08, jam wrote:
> > On 2014/05/01 22:03:31, boliu wrote:
> > > The correct way to do this currently is use a template file then generate
> the
> > > java and native files from the template at compile time. 
> > 
> > at a very large cost in terms of readability and searchability...
> > 
> > i know we've done this in the past, but those have been large lists. i
prefer
> > patchset 1 here
> 
> Either should solve the findbugs issue, so just let me know which to do. 
patch
> set 1 isn't really any worse than what's already there.

Go with Patch Set 1 then.

[vandebo (ex-Chrome), 2014-05-02 23:20:55]

On 2014/05/02 23:12:44, boliu wrote:
> On 2014/05/02 21:24:01, vandebo wrote:
> > On 2014/05/02 18:42:08, jam wrote:
> > > On 2014/05/01 22:03:31, boliu wrote:
> > > > The correct way to do this currently is use a template file then
generate
> > the
> > > > java and native files from the template at compile time. 
> > > 
> > > at a very large cost in terms of readability and searchability...
> > > 
> > > i know we've done this in the past, but those have been large lists. i
> prefer
> > > patchset 1 here
> > 
> > Either should solve the findbugs issue, so just let me know which to do. 
> patch
> > set 1 isn't really any worse than what's already there.
> 
> Go with Patch Set 1 then.

Done. LG?

[boliu, 2014-05-02 23:23:47]

lgtm

I guess you can carry forward benm's real lgtm for content :)

[vandebo (ex-Chrome), 2014-05-02 23:25:38]

The CQ bit was checked by vandebo@chromium.org

[commit-bot: I haz the power, 2014-05-02 23:26:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vandebo@chromium.org/268573002/80001

[commit-bot: I haz the power, 2014-05-03 02:33:14]

Change committed as 268012