Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2685723004: Revert "Use CodeSourceMap for stack traces (still JIT only)." (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use CodeSourceMap for stack traces (still JIT only)." Failed with app-jit snapshots. This reverts commit 7d2e6b161516fe4dfe09563c762b0ff19c9a705e. Committed: https://github.com/dart-lang/sdk/commit/9e3bd0ef0affc0335762d423b666b6405e8bf8e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -285 lines) Patch
M runtime/vm/code_descriptors.h View 4 chunks +22 lines, -56 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 5 chunks +31 lines, -106 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +20 lines, -26 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 5 chunks +11 lines, -20 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 2 chunks +3 lines, -11 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +66 lines, -41 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
rmacnak
3 years, 10 months ago (2017-02-08 21:33:29 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9e3bd0ef0affc0335762d423b666b6405e8bf8e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698