src/interpreter/bytecode-generator.h - Issue 2685683002: [async-await] (simpler) fix for Return in try/finally in async functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.h

Issue 2685683002: [async-await] (simpler) fix for Return in try/finally in async functions (Closed)

Patch Set: add some comments + cleanup using BuildHardReturn Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-generator.h

diff --git a/src/interpreter/bytecode-generator.h b/src/interpreter/bytecode-generator.h

index 12aeb28ce1794bb296a4c66728b7817fd033499d..75ce8b4263db6192b269aa8b43f4ee472b4a0703 100644

--- a/src/interpreter/bytecode-generator.h

+++ b/src/interpreter/bytecode-generator.h

@@ -105,6 +105,7 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {

HoleCheckMode hole_check_mode);

void BuildReturn();

+ void BuildHardReturn();

void BuildReThrow();

void BuildAbort(BailoutReason bailout_reason);

void BuildThrowIfHole(Handle<String> name);