Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2685673004: Handle Creates and Returns annotations in KernelBehaviorBuilder (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle Creates and Returns annotations in KernelBehaviorBuilder R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/cc60ef19f525ef107c11791a87feace990f74c98

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -83 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +3 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_adapter.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 10 chunks +62 lines, -46 lines 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-09 11:29:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2685673004/diff/1/pkg/compiler/lib/src/kernel/element_adapter.dart File pkg/compiler/lib/src/kernel/element_adapter.dart (right): https://codereview.chromium.org/2685673004/diff/1/pkg/compiler/lib/src/kernel/element_adapter.dart#newcode280 pkg/compiler/lib/src/kernel/element_adapter.dart:280: ; delete `;` :)
3 years, 10 months ago (2017-02-09 21:01:35 UTC) #3
Johnni Winther
https://codereview.chromium.org/2685673004/diff/1/pkg/compiler/lib/src/kernel/element_adapter.dart File pkg/compiler/lib/src/kernel/element_adapter.dart (right): https://codereview.chromium.org/2685673004/diff/1/pkg/compiler/lib/src/kernel/element_adapter.dart#newcode280 pkg/compiler/lib/src/kernel/element_adapter.dart:280: ; On 2017/02/09 21:01:35, Siggi Cherem (dart-lang) wrote: > ...
3 years, 10 months ago (2017-02-10 09:38:24 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-02-10 09:43:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cc60ef19f525ef107c11791a87feace990f74c98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698