Remove TabModel -replaceWebState: method.

ios/chrome/browser/tabs/tab_model_unittest.mm

Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index c9e60b5d9768c4c13a193d16e2f697a29a10ee18..3aa7aa0a51e64c4d59cd1b7613c38eb3a9ff2583 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -13,6 +13,7 @@
 #include "ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h"
 #include "ios/chrome/browser/chrome_url_constants.h"
 #include "ios/chrome/browser/infobars/infobar_manager_impl.h"
+#include "ios/chrome/browser/sessions/ios_chrome_session_tab_helper.h"
 #import "ios/chrome/browser/sessions/session_window.h"
 #import "ios/chrome/browser/sessions/test_session_service.h"
 #import "ios/chrome/browser/tabs/tab.h"
@@ -64,12 +65,6 @@ using web::WebStateImpl;
               lastVisitedTimestamp:(double)lastVisitedTimestamp
                       browserState:(ios::ChromeBrowserState*)browserState
                           tabModel:(TabModel*)tabModel {
-  self = [super initWithWindowName:windowName
-                            opener:nil
-                       openedByDOM:NO
-                             model:tabModel
-                      browserState:browserState];
-  if (self) {
     id webControllerMock =
         [OCMockObject niceMockForClass:[CRWWebController class]];
 
@@ -86,7 +81,10 @@ using web::WebStateImpl;
     BOOL yes = YES;
     [[[webControllerMock stub] andReturnValue:OCMOCK_VALUE(yes)] isViewAlive];
 
-    [self replaceWebState:std::move(webStateImpl)];
+    if ((self = [super initWithWebState:std::move(webStateImpl)

[marq (ping after 24h), 2017/02/07 18:39:04]

Prefer to keep the superclass init at the top of the method unless there's a
good reason not to.

If you don't, please fix the indent for the lines above.

[sdefresne, 2017/02/08 09:28:57]

There's a good reason: I need to create and WebStateImpl and its mock
CRWWebController before I can invoke the super class initialiser.

Indentation fixed (I expected that "git cl format" would have reformatted them
but then it only reformat the modified code and "git diff" was over optimistic
in not marking the body of the "if" as modified).

+                                  model:tabModel
+                       attachTabHelpers:NO])) {
+      IOSChromeSessionTabHelper::CreateForWebState(self.webState);
   }
   return self;
 }