Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: test/cctest/wasm/test-run-wasm.cc

Issue 2685583003: [wasm] Do not use setjmp/longjmp in cctests. (Closed)
Patch Set: Turn off signalling NaN tests in the simulator Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/wasm/test-run-wasm.cc
diff --git a/test/cctest/wasm/test-run-wasm.cc b/test/cctest/wasm/test-run-wasm.cc
index 05370b5775950d7bc1ba88203b37f56b0107a3e2..704d00c9f7cc157d3d14adf37c244b84d18f3499 100644
--- a/test/cctest/wasm/test-run-wasm.cc
+++ b/test/cctest/wasm/test-run-wasm.cc
@@ -1047,6 +1047,10 @@ WASM_EXEC_TEST(I32ReinterpretF32) {
}
}
+// Do not run this test in a simulator because of signalling NaN issues on ia32.
+#if (V8_HOST_ARCH_IA32 || V8_HOST_ARCH_X64) && \
Rodolph Perfetta (ARM) 2017/02/08 01:40:55 #ifndef USE_SIMULATOR
ahaas 2017/02/08 09:11:46 Done.
+ (V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64)
+
WASM_EXEC_TEST(SignallingNanSurvivesI32ReinterpretF32) {
WasmRunner<int32_t> r(execution_mode);
@@ -1057,6 +1061,8 @@ WASM_EXEC_TEST(SignallingNanSurvivesI32ReinterpretF32) {
CHECK_EQ(0x7fa00000, r.Call());
}
+#endif
+
WASM_EXEC_TEST_WITH_TRAP(LoadMaxUint32Offset) {
WasmRunner<int32_t> r(execution_mode);
r.module().AddMemoryElems<int32_t>(8);

Powered by Google App Engine
This is Rietveld 408576698