Chromium Code Reviews

Unified Diff: test/cctest/wasm/test-run-wasm-64.cc

Issue 2685583003: [wasm] Do not use setjmp/longjmp in cctests. (Closed)
Patch Set: Turn off signalling NaN tests in the simulator Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: test/cctest/wasm/test-run-wasm-64.cc
diff --git a/test/cctest/wasm/test-run-wasm-64.cc b/test/cctest/wasm/test-run-wasm-64.cc
index 4571364980604d4ca126dcd762116b1bc7c3a582..6944743a9f462feb992f35cdf6181185f813ea96 100644
--- a/test/cctest/wasm/test-run-wasm-64.cc
+++ b/test/cctest/wasm/test-run-wasm-64.cc
@@ -1319,6 +1319,10 @@ WASM_EXEC_TEST(I64ReinterpretF64) {
}
}
+// Do not run this test in a simulator because of signalling NaN issues on ia32.
+#if (V8_HOST_ARCH_IA32 || V8_HOST_ARCH_X64) && \
Rodolph Perfetta (ARM) 2017/02/08 01:40:55 This test will only run on ia32 or x64 now, if you
ahaas 2017/02/08 09:11:46 Thanks, I was not aware of this flag.
+ (V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64)
+
WASM_EXEC_TEST(SignallingNanSurvivesI64ReinterpretF64) {
REQUIRE(I64ReinterpretF64);
WasmRunner<int64_t> r(execution_mode);
@@ -1328,6 +1332,7 @@ WASM_EXEC_TEST(SignallingNanSurvivesI64ReinterpretF64) {
// This is a signalling nan.
CHECK_EQ(0x7ff4000000000000, r.Call());
}
+#endif
WASM_EXEC_TEST(F64ReinterpretI64) {
REQUIRE(F64ReinterpretI64);

Powered by Google App Engine