tools/clang/blink_gc_plugin/tests/stack_allocated.h - Issue 2685583002: blink_gc_plugin: warn of unused trace methods to stack allocated classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/stack_allocated.h

Issue 2685583002: blink_gc_plugin: warn of unused trace methods to stack allocated classes. (Closed)

Patch Set: rebased upto r449038 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/tests/stack_allocated.h

diff --git a/tools/clang/blink_gc_plugin/tests/stack_allocated.h b/tools/clang/blink_gc_plugin/tests/stack_allocated.h

index 574219c594cf92c9f7035b7dfc05d856fd26726d..50a4632a987270865964e6a61fe6de6fe52014c2 100644

--- a/tools/clang/blink_gc_plugin/tests/stack_allocated.h

+++ b/tools/clang/blink_gc_plugin/tests/stack_allocated.h

@@ -19,6 +19,10 @@ private:

class StackObject {

STACK_ALLOCATED();

+ // Redundant trace() method, warning/error expected.

+ void Trace(Visitor* visitor) { visitor->Trace(m_obj); }

private:

Member<HeapObject> m_obj; // Does not need tracing.

};