tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp - Issue 2685583002: blink_gc_plugin: warn of unused trace methods to stack allocated classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

Issue 2685583002: blink_gc_plugin: warn of unused trace methods to stack allocated classes. (Closed)

Patch Set: rebased upto r449038 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

index c15b8e8f2bb7e9454b7482e0f08a730cdec83055..28af4bc098c5aa62af72bed93d51b7b8f0cb722c 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

@@ -181,6 +181,8 @@ void BlinkGCPluginConsumer::CheckClass(RecordInfo* info) {

return;

if (CXXMethodDecl* trace = info->GetTraceMethod()) {

+ if (options_.warn_stack_allocated_trace_method && info->IsStackAllocated())

+ reporter_.TraceMethodForStackAllocatedClass(info, trace);

if (trace->isPure())

reporter_.ClassDeclaresPureVirtualTrace(info, trace);

} else if (info->RequiresTraceMethod()) {