pkg/compiler/lib/src/compiler.dart - Issue 2685573002: Replace Backend with JavaScriptBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2685573002: Replace Backend with JavaScriptBackend. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/common/resolution.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | pkg/compiler/lib/src/js_backend/backend.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/compiler.dart

diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart

index 760604cd9779d9b6f00276a65fea2816ef5eb5b4..ef7f84c18c313bbe360258ac33a7e177fd8ec9f6 100644

--- a/pkg/compiler/lib/src/compiler.dart

+++ b/pkg/compiler/lib/src/compiler.dart

@@ -8,7 +8,6 @@ import 'dart:async' show EventSink, Future;

import '../compiler_new.dart' as api;

import 'closure.dart' as closureMapping show ClosureTask;

-import 'common/backend_api.dart' show Backend;

import 'common/names.dart' show Selectors;

import 'common/names.dart' show Identifiers, Uris;

import 'common/resolution.dart'

@@ -81,7 +80,7 @@ import 'universe/world_impact.dart'

import 'util/util.dart' show Link, Setlet;

import 'world.dart' show ClosedWorld, ClosedWorldRefiner, ClosedWorldImpl;

-typedef Backend MakeBackendFunction(Compiler compiler);

+typedef js_backend.JavaScriptBackend MakeBackendFunction(Compiler compiler);

Siggi Cherem (dart-lang) 2017/02/08 00:10:03 we might want to add a todo to remove this, we sho

Johnni Winther 2017/02/08 09:46:35 Done.

typedef CompilerDiagnosticReporter MakeReporterFunction(

Compiler compiler, CompilerOptions options);

@@ -163,7 +162,7 @@ abstract class Compiler implements LibraryLoaderListener {

closureMapping.ClosureTask closureToClassMapper;

TypeCheckerTask checker;

GlobalTypeInferenceTask globalInference;

- Backend backend;

+ js_backend.JavaScriptBackend backend;

GenericTask selfTask;

@@ -271,7 +270,7 @@ abstract class Compiler implements LibraryLoaderListener {

/// Creates the backend.

///

/// Override this to mock the backend for testing.

- Backend createBackend() {

+ js_backend.JavaScriptBackend createBackend() {

return new js_backend.JavaScriptBackend(this,

generateSourceMap: options.generateSourceMap,

useStartupEmitter: options.useStartupEmitter,

« no previous file with comments | « pkg/compiler/lib/src/common/resolution.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | pkg/compiler/lib/src/js_backend/backend.dart » ('J')