Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2685573002: Replace Backend with JavaScriptBackend. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -413 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +0 lines, -301 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 6 chunks +3 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 4 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 34 chunks +166 lines, -56 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +12 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 5 chunks +4 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/getters_setters_test.dart View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-07 13:33:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2685573002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2685573002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode83 pkg/compiler/lib/src/compiler.dart:83: typedef js_backend.JavaScriptBackend MakeBackendFunction(Compiler compiler); we might want to ...
3 years, 10 months ago (2017-02-08 00:10:03 UTC) #3
Johnni Winther
https://codereview.chromium.org/2685573002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2685573002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode83 pkg/compiler/lib/src/compiler.dart:83: typedef js_backend.JavaScriptBackend MakeBackendFunction(Compiler compiler); On 2017/02/08 00:10:03, Siggi Cherem ...
3 years, 10 months ago (2017-02-08 09:46:35 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-02-08 09:51:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
52efadefc21d47ed605d789ad1d55e2bf194cb11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698