third_party/WebKit/Source/core/workers/AbstractWorker.cpp - Issue 2685543002: Support data URLs in worker constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/AbstractWorker.cpp

Issue 2685543002: Support data URLs in worker constructors (Closed)

Patch Set: Added additional test for invalid javascript data: worker Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/AbstractWorker.cpp

diff --git a/third_party/WebKit/Source/core/workers/AbstractWorker.cpp b/third_party/WebKit/Source/core/workers/AbstractWorker.cpp

index 2cc20f4a8c19acb1a1c4b8bf22b94a671ec868c9..8ff9ac2a77875132bdbc7669bc04d1e521afc3c1 100644

--- a/third_party/WebKit/Source/core/workers/AbstractWorker.cpp

+++ b/third_party/WebKit/Source/core/workers/AbstractWorker.cpp

@@ -57,7 +57,8 @@ KURL AbstractWorker::resolveURL(const String& url,

// We can safely expose the URL in the following exceptions, as these checks

// happen synchronously before redirection. JavaScript receives no new

// information.

- if (!getExecutionContext()->getSecurityOrigin()->canRequestNoSuborigin(

+ if (!scriptURL.protocolIsData() &&

+ !getExecutionContext()->getSecurityOrigin()->canRequestNoSuborigin(

scriptURL)) {

exceptionState.throwSecurityError(

"Script at '" + scriptURL.elidedString() +