Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 268553003: Remove unreachable code. (Closed)

Created:
6 years, 7 months ago by Peter Kasting
Modified:
6 years, 7 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Remove unreachable code. BUG=346399 TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173228

Patch Set 1 #

Patch Set 2 : Move ASSERT instead of deleting it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/css/MediaValues.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Kasting
Did you instead intend to leave this ASSERT above the return?
6 years, 7 months ago (2014-05-01 00:57:56 UTC) #1
Yoav Weiss
On 2014/05/01 00:57:56, Peter Kasting wrote: > Did you instead intend to leave this ASSERT ...
6 years, 7 months ago (2014-05-01 06:10:46 UTC) #2
Yoav Weiss
On 2014/05/01 06:10:46, Yoav Weiss wrote: > On 2014/05/01 00:57:56, Peter Kasting wrote: > > ...
6 years, 7 months ago (2014-05-01 06:19:05 UTC) #3
Peter Kasting
On 2014/05/01 06:19:05, Yoav Weiss wrote: > On 2014/05/01 06:10:46, Yoav Weiss wrote: > > ...
6 years, 7 months ago (2014-05-01 20:18:21 UTC) #4
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 7 months ago (2014-05-02 19:08:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/268553003/20001
6 years, 7 months ago (2014-05-02 19:08:56 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 21:11:32 UTC) #7
Message was sent while issue was closed.
Change committed as 173228

Powered by Google App Engine
This is Rietveld 408576698