Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 268553002: Move DOMActivityLogger and associated code from //chrome to //extensions (Closed)

Created:
6 years, 7 months ago by James Cook
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move DOMActivityLogger and associated code from //chrome to //extensions This is a follow-up to rockot's CL to move extensions::Dispatcher and a precondition to moving c/r/e/extension_helper.cc. This was entirely a mechanical move -- no functional changes. BUG=359836 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -709 lines) Patch
M chrome/browser/extensions/activity_log/activity_actions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/uma_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/uma_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/ad_injection_constants.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/extensions/ad_injection_constants.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/common/extensions/dom_action_types.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/renderer/extensions/activity_log_converter_strategy.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/renderer/extensions/activity_log_converter_strategy.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/renderer/extensions/activity_log_converter_strategy_unittest.cc View 1 chunk +0 lines, -172 lines 0 comments Download
M chrome/renderer/extensions/api_activity_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/renderer/extensions/dom_activity_logger.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/renderer/extensions/dom_activity_logger.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 2 chunks +1 line, -1 line 0 comments Download
A + extensions/common/ad_injection_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/ad_injection_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/dom_action_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 4 chunks +7 lines, -0 lines 0 comments Download
A + extensions/renderer/activity_log_converter_strategy.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/activity_log_converter_strategy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/activity_log_converter_strategy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/dom_activity_logger.h View 2 chunks +4 lines, -8 lines 0 comments Download
A + extensions/renderer/dom_activity_logger.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
James Cook
kalman, PTAL. I'll rebase on top of rockot's CL once it lands. rockot, FYI
6 years, 7 months ago (2014-04-30 21:56:42 UTC) #1
not at google - send to devlin
lgtm I suppose, but what part of extension helper needs this moved? +devlin FYI.
6 years, 7 months ago (2014-04-30 22:00:05 UTC) #2
Devlin
On 2014/04/30 22:00:05, kalman wrote: > lgtm I suppose, but what part of extension helper ...
6 years, 7 months ago (2014-04-30 22:05:48 UTC) #3
Ken Rockot(use gerrit already)
On 2014/04/30 22:05:48, D Cronin wrote: > On 2014/04/30 22:00:05, kalman wrote: > > lgtm ...
6 years, 7 months ago (2014-04-30 22:29:22 UTC) #4
not at google - send to devlin
On 2014/04/30 22:29:22, Ken Rockot wrote: > On 2014/04/30 22:05:48, D Cronin wrote: > > ...
6 years, 7 months ago (2014-04-30 22:32:43 UTC) #5
James Cook
On 2014/04/30 22:32:43, kalman wrote: > On 2014/04/30 22:29:22, Ken Rockot wrote: > > On ...
6 years, 7 months ago (2014-04-30 22:35:08 UTC) #6
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 7 months ago (2014-05-01 05:06:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/268553002/1
6 years, 7 months ago (2014-05-01 05:06:45 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 09:05:47 UTC) #9
Message was sent while issue was closed.
Change committed as 267502

Powered by Google App Engine
This is Rietveld 408576698