src/inspector/java-script-call-frame.h - Issue 2685483002: [debugger] expose side-effect free evaluate to inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/java-script-call-frame.h

Issue 2685483002: [debugger] expose side-effect free evaluate to inspector. (Closed)

Patch Set: add inspector test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/java-script-call-frame.h

diff --git a/src/inspector/java-script-call-frame.h b/src/inspector/java-script-call-frame.h

index e8ae37d8196847ffda5189ed6f5472f4d1242812..b3930c0818a93ca71add07b71c40e1438f2b373a 100644

--- a/src/inspector/java-script-call-frame.h

+++ b/src/inspector/java-script-call-frame.h

@@ -54,7 +54,8 @@ class JavaScriptCallFrame {

bool isAtReturn() const;

v8::MaybeLocal<v8::Object> details() const;

- v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression);

+ v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression,

+ bool throwOnSideEffect);

v8::MaybeLocal<v8::Value> restart();

v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber,

v8::Local<v8::Value> variableName,

« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | src/inspector/java-script-call-frame.cc » ('j') | no next file with comments »