src/inspector/v8-debugger-agent-impl.h - Issue 2685483002: [debugger] expose side-effect free evaluate to inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/v8-debugger-agent-impl.h

Issue 2685483002: [debugger] expose side-effect free evaluate to inspector. (Closed)

Patch Set: tag as experimental Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/v8-debugger-agent-impl.h

diff --git a/src/inspector/v8-debugger-agent-impl.h b/src/inspector/v8-debugger-agent-impl.h

index d5b174a76c8a546e0a0f2c8d901fec613bd31e29..329163a68561fe27791cde949f0391a37c6be8ab 100644

--- a/src/inspector/v8-debugger-agent-impl.h

+++ b/src/inspector/v8-debugger-agent-impl.h

@@ -93,7 +93,7 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {

const String16& callFrameId, const String16& expression,

Maybe<String16> objectGroup, Maybe<bool> includeCommandLineAPI,

Maybe<bool> silent, Maybe<bool> returnByValue,

- Maybe<bool> generatePreview,

+ Maybe<bool> generatePreview, Maybe<bool> throwOnSideEffect,

std::unique_ptr<protocol::Runtime::RemoteObject>* result,

Maybe<protocol::Runtime::ExceptionDetails>*) override;

Response setVariableValue(