Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/inspector/debugger_script_externs.js

Issue 2685483002: [debugger] expose side-effect free evaluate to inspector. (Closed)
Patch Set: tag as experimental Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/debugger_script_externs.js
diff --git a/src/inspector/debugger_script_externs.js b/src/inspector/debugger_script_externs.js
index c1c45c756c8b60437bcfb5b83c76809f45e763b1..6289937f25a6d7114567f28bc7fa06c77531328c 100644
--- a/src/inspector/debugger_script_externs.js
+++ b/src/inspector/debugger_script_externs.js
@@ -31,7 +31,7 @@ var JavaScriptCallFrameDetails;
/** @typedef {{
contextId: function():number,
thisObject: !Object,
- evaluate: function(string):*,
+ evaluate: function(string, boolean):*,
restart: function():undefined,
setVariableValue: function(number, string, *):undefined,
isAtReturn: boolean,
@@ -360,8 +360,9 @@ FrameMirror.prototype.script = function() {}
/**
* @param {string} source
+ * @param {boolean} throwOnSideEffect
*/
-FrameMirror.prototype.evaluate = function(source) {}
+FrameMirror.prototype.evaluate = function(source, throwOnSideEffect) {}
FrameMirror.prototype.restart = function() {}

Powered by Google App Engine
This is Rietveld 408576698