Cross-process iframe accessibility.

content/browser/accessibility/browser_accessibility.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
 
 #include <map>
 #include <utility>
 #include <vector>
@@ skipping 13 matching lines @@
 namespace content {
 class BrowserAccessibilityManager;
 #if defined(OS_WIN)
 class BrowserAccessibilityWin;
 #endif
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // BrowserAccessibility
 //
 // Class implementing the cross platform interface for the Browser-Renderer

[Charlie Reis, 2014/08/20 20:37:13]

Do we have a separate instance of this class for each FrameTreeNode?  I'm
unclear why it would have a frame ID member, since this comment makes it sound
like there's only one for the browser.

[dmazzoni, 2014/08/20 20:57:17]

Sorry, I haven't updated that comment in years. There's an instance of this for
practically every element on the page. I'll be renaming this AXPlatformNode
soon, and BrowserAccessibilityManager -> AXPlatformTree.

[dmazzoni, 2014/08/25 06:49:36]

Comment updated a bit.

 // communication of accessibility information, providing accessibility
 // to be used by screen readers and other assistive technology (AT).
 //
 // An implementation for each platform handles platform specific accessibility
 // APIs.
 //
 ////////////////////////////////////////////////////////////////////////////////
 class CONTENT_EXPORT BrowserAccessibility {
  public:
   // Creates a platform specific BrowserAccessibility. Ownership passes to the
@@ skipping 193 matching lines @@
 
   // Returns true if the bit corresponding to the given state enum is 1.
   bool HasState(ui::AXState state_enum) const;
 
   // Returns true if this node is an editable text field of any kind.
   bool IsEditableText() const;
 
   // Append the text from this node and its children.
   std::string GetTextRecursive() const;
 
+  // Identifies the given frame id as the only child of this node, so

[Charlie Reis, 2014/08/20 20:37:13]

I don't follow why this would track a single child.  What if there were
multiple?

[dmazzoni, 2014/08/20 20:57:17]

This object would correspond to an actual <iframe> element on a page. It'd have
one child, the child frame.

+  // any call to PlatformChildCount/PlatformGetChild will use
+  // FrameTreeAccessibility to retrieve the BrowserAccessibilityManager
+  // of the child frame and return its root node as this node's child.
+  void SetChildFrameId(int64 child_frame_id);

[Charlie Reis, 2014/08/20 20:37:13]

nit: FrameId is ambiguous, between a RenderFrame routing ID and a FrameTreeNode
ID.  Can you clarify which one you mean, here and below?

[dmazzoni, 2014/08/20 20:57:17]

Agreed, let me clarify.

[dmazzoni, 2014/08/25 06:49:36]

Done.

+
  protected:
   BrowserAccessibility();
 
   // The manager of this tree of accessibility objects.
   BrowserAccessibilityManager* manager_;
 
   // The underlying node.
   ui::AXNode* node_;
 
  private:
   // Return the sum of the lengths of all static text descendants,
   // including this object if it's static text.
   int GetStaticTextLenRecursive() const;
 
   std::string name_;
   std::string value_;
 
- private:
+  int64 child_frame_id_;
+
   DISALLOW_COPY_AND_ASSIGN(BrowserAccessibility);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_