Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 268543005: Revert of Handle media access permission request (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Handle media access permission request (https://codereview.chromium.org/239793002/) Reason for revert: It looks like this broke Android builder: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28db... In file included from ../../android_webview/native/permission/aw_permission_request_delegate.cc:5:0: ../../android_webview/native/permission/aw_permission_request_delegate.h:8:37: fatal error: base/android/jni_helper.h: No such file or directory compilation terminated. etc Original issue's description: > This patch is also implements the general permission request. > > - AwPermissionRequest wraps a permission request. > - AwPermissionRequestDelegate interface should be implemented by specific permission request like media access permission request. > - PermissionRequestHandler, send the request to AwContentsClient or Cancel a ongoing request. > > NOTRY=true > BUG=363301 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267495 NOTREECHECKS=true NOTRY=true BUG=363301 TBR=michaelbai Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1104 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +0 lines, -11 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 2 chunks +0 lines, -8 lines 0 comments Download
D android_webview/java/src/org/chromium/android_webview/permission/AwPermissionRequest.java View 1 chunk +0 lines, -89 lines 0 comments Download
M android_webview/lib/main/webview_tests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/android_webview_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents.h View 5 chunks +1 line, -14 lines 0 comments Download
M android_webview/native/aw_contents.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 3 chunks +0 lines, -19 lines 0 comments Download
D android_webview/native/permission/aw_permission_request.h View 1 chunk +0 lines, -70 lines 0 comments Download
D android_webview/native/permission/aw_permission_request.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D android_webview/native/permission/aw_permission_request_delegate.h View 1 chunk +0 lines, -36 lines 0 comments Download
D android_webview/native/permission/aw_permission_request_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D android_webview/native/permission/media_access_permission_request.h View 1 chunk +0 lines, -41 lines 0 comments Download
D android_webview/native/permission/media_access_permission_request.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D android_webview/native/permission/media_access_permission_request_unittest.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D android_webview/native/permission/permission_request_handler.h View 1 chunk +0 lines, -60 lines 0 comments Download
D android_webview/native/permission/permission_request_handler.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D android_webview/native/permission/permission_request_handler_client.h View 1 chunk +0 lines, -23 lines 0 comments Download
D android_webview/native/permission/permission_request_handler_client.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D android_webview/native/permission/permission_request_handler_unittest.cc View 1 chunk +0 lines, -269 lines 0 comments Download
M android_webview/native/webview_native.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M android_webview/test/shell/AndroidManifest.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/NullContentsClient.java View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
falken
Created Revert of Handle media access permission request
6 years, 7 months ago (2014-05-01 09:13:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/268543005/1
6 years, 7 months ago (2014-05-01 09:13:33 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 09:13:34 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-01 09:13:34 UTC) #4
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-05-01 09:15:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/268543005/1
6 years, 7 months ago (2014-05-01 09:15:58 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 09:17:13 UTC) #7
Message was sent while issue was closed.
Change committed as 267503

Powered by Google App Engine
This is Rietveld 408576698