Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2194)

Unified Diff: cc/surfaces/surface_manager_ref_unittest.cc

Issue 2685393003: Surfaces: Allow parent to refer to child surfaces that don't exist yet. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager_ref_unittest.cc
diff --git a/cc/surfaces/surface_manager_ref_unittest.cc b/cc/surfaces/surface_manager_ref_unittest.cc
index 476cc8c492d9f470533d49b76d753c4281aa4f78..5f68c165f78294eafbd8aab5575e3a81ec3855e2 100644
--- a/cc/surfaces/surface_manager_ref_unittest.cc
+++ b/cc/surfaces/surface_manager_ref_unittest.cc
@@ -266,17 +266,6 @@ TEST_F(SurfaceManagerRefTest, CheckGCRecusiveFull) {
EXPECT_EQ(nullptr, manager().GetSurfaceForId(id3));
}
-TEST_F(SurfaceManagerRefTest, TryAddReferenceToBadSurface) {
- // Not creating an accompanying Surface and SurfaceFactory.
- SurfaceId id(FrameSinkId(100u, 200u),
- LocalSurfaceId(1u, base::UnguessableToken::Create()));
-
- // Adding reference from root to the Surface should do nothing because
- // SurfaceManager doesn't know Surface for |id| exists.
- manager().AddSurfaceReference(manager().GetRootSurfaceId(), id);
- EXPECT_THAT(GetReferencesFor(id), IsEmpty());
-}
-
TEST_F(SurfaceManagerRefTest, TryDoubleAddReference) {
SurfaceId id1 = CreateSurface(kFrameSink1, 1);
SurfaceId id2 = CreateSurface(kFrameSink2, 1);
« no previous file with comments | « cc/surfaces/surface_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698