Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 2685363002: Update AppBannerManager & AppBannerManagerAndroid to request badge icon. (Closed)
Patch Set: Addressing comments (move can_install init to constructor) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.h
diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h
index 4e0ea6a83131283c093c2f5299766b701d364bbb..92f8ce086dc6fcb570b6711926cf2b1088f019ca 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.h
+++ b/chrome/browser/android/banners/app_banner_manager_android.h
@@ -65,15 +65,20 @@ class AppBannerManagerAndroid
static bool Register(JNIEnv* env);
protected:
+ // Return the ideal badge icon size.
+ int GetIdealBadgeIconSizeInPx();
+
// AppBannerManager overrides.
std::string GetAppIdentifier() override;
std::string GetBannerType() override;
- int GetIdealIconSizeInPx() override;
- int GetMinimumIconSizeInPx() override;
+ int GetIdealPrimaryIconSizeInPx() override;
+ int GetMinimumPrimaryIconSizeInPx() override;
bool IsWebAppInstalled(content::BrowserContext* browser_context,
const GURL& start_url,
const GURL& manifest_url) override;
+ InstallableParams ParamsToPerformInstallableCheck() override;
void PerformInstallableCheck() override;
+ void OnDidPerformInstallableCheck(const InstallableData& result) override;
void OnAppIconFetched(const SkBitmap& bitmap) override;
void ResetCurrentPageData() override;
void ShowBanner() override;
@@ -101,6 +106,12 @@ class AppBannerManagerAndroid
const GURL& url,
const std::string& id);
+ // The URL of the badge icon.
+ GURL badge_icon_url_;
+
+ // The badge icon object.
+ std::unique_ptr<SkBitmap> badge_icon_;
+
// The Java-side AppBannerManager.
base::android::ScopedJavaGlobalRef<jobject> java_banner_manager_;
@@ -110,6 +121,9 @@ class AppBannerManagerAndroid
// App package name for a native app banner.
std::string native_app_package_;
+ // Whether WebAPKs can be installed.
+ bool can_install_webapk_;
+
DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid);
};
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698