Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2685363002: Update AppBannerManager & AppBannerManagerAndroid to request badge icon. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index e5dab9f1c095494a4b6384c83320e833f2e2b4ff..68fddb4026c89ffc7a2d8367f50385008d638fc9 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -120,9 +120,10 @@ class AppBannerManager : public content::WebContentsObserver,
// |code|. Returns the empty string if |code| requires no parameter.
std::string GetStatusParam(InstallableStatusCode code);
- // Returns the ideal and minimum icon sizes required for being installable.
- virtual int GetIdealIconSizeInPx();
- virtual int GetMinimumIconSizeInPx();
+ // Returns the ideal and minimum size requirements for icons.
+ virtual int GetIdealPrimaryIconSizeInPx();
+ virtual int GetMinimumPrimaryIconSizeInPx();
+ virtual int GetIdealBadgeIconSizeInPx();
// Returns a WeakPtr to this object. Exposed so subclasses/infobars may
// may bind callbacks without needing their own WeakPtrFactory.
@@ -208,11 +209,13 @@ class AppBannerManager : public content::WebContentsObserver,
// The manifest object.
content::Manifest manifest_;
- // The URL of the icon.
- GURL icon_url_;
+ // Icon URLs.
+ GURL primary_icon_url_;
+ GURL badge_icon_url_;
- // The icon object.
- std::unique_ptr<SkBitmap> icon_;
+ // Icon objects.
+ std::unique_ptr<SkBitmap> primary_icon_;
+ std::unique_ptr<SkBitmap> badge_icon_;
// The referrer string (if any) specified in the app URL. Used only for native
// app banners.

Powered by Google App Engine
This is Rietveld 408576698