Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/in_process_browser_test_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc
index 99651be200f6cb2089728671d4fbc77fc258d997..11abd4407ea0ffa15d31cdd08f686458f2fa129c 100644
--- a/chrome/test/base/in_process_browser_test.cc
+++ b/chrome/test/base/in_process_browser_test.cc
@@ -446,22 +446,22 @@ Browser* InProcessBrowserTest::OpenURLOffTheRecord(Profile* profile,
// Creates a browser with a single tab (about:blank), waits for the tab to
// finish loading and shows the browser.
Browser* InProcessBrowserTest::CreateBrowser(Profile* profile) {
- Browser* browser = new Browser(Browser::CreateParams(profile));
+ Browser* browser = new Browser(Browser::CreateParams(profile, true));
AddBlankTabAndShow(browser);
return browser;
}
Browser* InProcessBrowserTest::CreateIncognitoBrowser() {
// Create a new browser with using the incognito profile.
- Browser* incognito = new Browser(
- Browser::CreateParams(browser()->profile()->GetOffTheRecordProfile()));
+ Browser* incognito = new Browser(Browser::CreateParams(
+ browser()->profile()->GetOffTheRecordProfile(), true));
AddBlankTabAndShow(incognito);
return incognito;
}
Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
Browser* browser =
- new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile));
+ new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile, true));
AddBlankTabAndShow(browser);
return browser;
}
@@ -469,9 +469,8 @@ Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
Browser* InProcessBrowserTest::CreateBrowserForApp(
const std::string& app_name,
Profile* profile) {
- Browser* browser = new Browser(
- Browser::CreateParams::CreateForApp(
- app_name, false /* trusted_source */, gfx::Rect(), profile));
+ Browser* browser = new Browser(Browser::CreateParams::CreateForApp(
+ app_name, false /* trusted_source */, gfx::Rect(), profile, true));
AddBlankTabAndShow(browser);
return browser;
}
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/in_process_browser_test_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698