Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
diff --git a/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc b/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
index 7c71a2f0d5c237cf24e55c99cac8b00b04cc26eb..a1398fe4482d277a824f3458df14d5ff7a373557 100644
--- a/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
+++ b/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
@@ -48,12 +48,12 @@ TEST_F(BrowserListTest, TabContentsIteratorVerifyCount) {
EXPECT_EQ(0U, CountAllTabs());
// Create more browsers/windows.
- Browser::CreateParams native_params(profile());
+ Browser::CreateParams native_params(profile(), true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&native_params));
// Create browser 3 and 4 on the Ash desktop (the TabContentsIterator
// shouldn't see the difference).
- Browser::CreateParams ash_params(profile());
+ Browser::CreateParams ash_params(profile(), true);
std::unique_ptr<Browser> browser3(
chrome::CreateBrowserWithTestWindowForParams(&ash_params));
std::unique_ptr<Browser> browser4(
@@ -94,12 +94,12 @@ TEST_F(BrowserListTest, TabContentsIteratorVerifyBrowser) {
EXPECT_EQ(1U, BrowserList::GetInstance()->size());
// Create more browsers/windows.
- Browser::CreateParams native_params(profile());
+ Browser::CreateParams native_params(profile(), true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&native_params));
// Create browser 3 on the Ash desktop (the TabContentsIterator shouldn't see
// the difference).
- Browser::CreateParams ash_params(profile());
+ Browser::CreateParams ash_params(profile(), true);
std::unique_ptr<Browser> browser3(
chrome::CreateBrowserWithTestWindowForParams(&ash_params));
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter.cc ('k') | chrome/browser/ui/tabs/pinned_tab_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698