Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5391)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index 27e34043f8ff2dead8ce8ba2338324c9a507d68c..1a1b9ffd8818de1d596c9996a0a26f6f746aab2c 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -1333,7 +1333,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate) {
// Open a new incognito window and navigate to the same page.
Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();
Browser* incognito_browser =
- new Browser(Browser::CreateParams(incognito_profile));
+ new Browser(Browser::CreateParams(incognito_profile, true));
content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
@@ -1394,7 +1394,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, ActivateLinkNavigatesPage) {
}
IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FitWindow) {
- Browser::CreateParams params(Browser::TYPE_POPUP, browser()->profile());
+ Browser::CreateParams params(Browser::TYPE_POPUP, browser()->profile(), true);
params.initial_bounds = gfx::Rect(0, 0, 250, 500);
Browser* popup = new Browser(params);
content::WindowedNotificationObserver observer(

Powered by Google App Engine
This is Rietveld 408576698