chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index 88b942292138986d78841cf3901a03879c645b5d..bac5b5faab13f82ed079aacc04debad4c2ce2f59 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -93,7 +93,7 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

- (void)openURLForNode:(const BookmarkNode*)node {

Browser* browser = chrome::FindTabbedBrowser(bridge_->GetProfile(), true);

if (!browser) {

- browser = new Browser(Browser::CreateParams(bridge_->GetProfile()));

+ browser = new Browser(Browser::CreateParams(bridge_->GetProfile(), true));

}

WindowOpenDisposition disposition =

ui::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);

@@ -113,7 +113,7 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

Browser* browser = chrome::FindTabbedBrowser(bridge_->GetProfile(), true);

if (!browser) {

- browser = new Browser(Browser::CreateParams(bridge_->GetProfile()));

+ browser = new Browser(Browser::CreateParams(bridge_->GetProfile(), true));

}

DCHECK(browser);