Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/ui/browser_finder_chromeos_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_finder_chromeos_unittest.cc
diff --git a/chrome/browser/ui/browser_finder_chromeos_unittest.cc b/chrome/browser/ui/browser_finder_chromeos_unittest.cc
index c9802e2b1e1d1a8f3b7f87cf1459fd03b2e016ea..00e9400ae83829bbdc0f2ce5e9cd89f7d4494dd8 100644
--- a/chrome/browser/ui/browser_finder_chromeos_unittest.cc
+++ b/chrome/browser/ui/browser_finder_chromeos_unittest.cc
@@ -116,7 +116,7 @@ TEST_F(BrowserFinderChromeOSTest, IncognitoBrowserMatchTest) {
set_browser(nullptr);
// Create an incognito browser.
- Browser::CreateParams params(profile()->GetOffTheRecordProfile());
+ Browser::CreateParams params(profile()->GetOffTheRecordProfile(), true);
std::unique_ptr<Browser> incognito_browser(
chrome::CreateBrowserWithAuraTestWindowForParams(nullptr, &params));
// Incognito windows are excluded in GetBrowserCount() because kMatchAll
@@ -129,7 +129,7 @@ TEST_F(BrowserFinderChromeOSTest, IncognitoBrowserMatchTest) {
TEST_F(BrowserFinderChromeOSTest, FindBrowserOwnedByAnotherProfile) {
set_browser(nullptr);
- Browser::CreateParams params(profile()->GetOriginalProfile());
+ Browser::CreateParams params(profile()->GetOriginalProfile(), true);
std::unique_ptr<Browser> browser(
chrome::CreateBrowserWithAuraTestWindowForParams(nullptr, &params));
GetUserWindowManager()->SetWindowOwner(browser->window()->GetNativeWindow(),
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698