Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5869)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_close_unittest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index ee63765fe5508834673edd0e6ad399b019dc081d..53bce11480d9da0f76e3dac8bde802e51e7bb5d8 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -231,7 +231,7 @@ TEST_F(BrowserCommandControllerTest, AvatarMenuAlwaysDisabledInIncognitoMode) {
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(
- original_profile->GetOffTheRecordProfile());
+ original_profile->GetOffTheRecordProfile(), true);
std::unique_ptr<Browser> otr_browser(
chrome::CreateBrowserWithTestWindowForParams(&profile_params));
@@ -456,7 +456,8 @@ TEST_F(BrowserCommandControllerTest, IncognitoModeOnSigninAllowedPrefChange) {
EXPECT_EQ(profile2->GetOriginalProfile(), profile1.get());
// Create a new browser based on the off the record profile.
- Browser::CreateParams profile_params(profile1->GetOffTheRecordProfile());
+ Browser::CreateParams profile_params(profile1->GetOffTheRecordProfile(),
+ true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&profile_params));
« no previous file with comments | « chrome/browser/ui/browser_close_unittest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698