chrome/browser/ui/ash/accelerator_commands_browsertest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

diff --git a/chrome/browser/ui/ash/accelerator_commands_browsertest.cc b/chrome/browser/ui/ash/accelerator_commands_browsertest.cc

index bb8a461dde7b8b748e3adf0174e12337b75a98c2..40d7547d1c6e5d35f75d71befe224438823700e0 100644

--- a/chrome/browser/ui/ash/accelerator_commands_browsertest.cc

+++ b/chrome/browser/ui/ash/accelerator_commands_browsertest.cc

@@ -149,7 +149,8 @@ IN_PROC_BROWSER_TEST_P(AcceleratorCommandsFullscreenBrowserTest,

// 3) Hosted apps.

Browser::CreateParams browser_create_params(

Browser::CreateParams::CreateForApp("Test", true /* trusted_source */,

- gfx::Rect(), browser()->profile()));

+ gfx::Rect(), browser()->profile(),

+ true));

Browser* app_host_browser = new Browser(browser_create_params);

ASSERT_TRUE(app_host_browser->is_app());

@@ -169,7 +170,7 @@ IN_PROC_BROWSER_TEST_P(AcceleratorCommandsFullscreenBrowserTest,

// 4) Popup browser windows.

browser_create_params =

- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile());

+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true);

Browser* popup_browser = new Browser(browser_create_params);

ASSERT_TRUE(popup_browser->is_type_popup());

ASSERT_FALSE(popup_browser->is_app());