chrome/browser/ssl/security_state_tab_helper_browser_tests.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/security_state_tab_helper_browser_tests.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/session_restore_browsertest_chromeos.cc ('k') | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/security_state_tab_helper_browser_tests.cc

diff --git a/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc b/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc

index f809ba1d33d31701b88104333b3a120aef4a12ef..e0a50dd10c5c36eb9dded33fa252bd93f571e55b 100644

--- a/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc

+++ b/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc

@@ -1289,7 +1289,7 @@ void CheckForOneFutureHttpWarningConsoleMessage(

IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,

ConsoleMessage) {

ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(

- Browser::CreateParams(browser()->profile()));

+ Browser::CreateParams(browser()->profile(), true));

content::WebContents* original_contents =

browser()->tab_strip_model()->GetActiveWebContents();

content::WebContents* contents =

@@ -1359,7 +1359,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTest, ConsoleMessage) {

ASSERT_TRUE(embedded_test_server()->Start());

host_resolver()->AddRule("*", embedded_test_server()->GetURL("/").host());

ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(

- Browser::CreateParams(browser()->profile()));

+ Browser::CreateParams(browser()->profile(), true));

content::WebContents* original_contents =

browser()->tab_strip_model()->GetActiveWebContents();

content::WebContents* contents =

@@ -1448,7 +1448,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTest, ConsoleMessage) {

IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,

ConsoleMessageNotPrintedForFrameNavigation) {

ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(

- Browser::CreateParams(browser()->profile()));

+ Browser::CreateParams(browser()->profile(), true));

content::WebContents* original_contents =

browser()->tab_strip_model()->GetActiveWebContents();

content::WebContents* contents =

@@ -1529,7 +1529,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,

IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,

ConsoleMessageNotPrintedForPushStateNavigation) {

ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(

- Browser::CreateParams(browser()->profile()));

+ Browser::CreateParams(browser()->profile(), true));

content::WebContents* original_contents =

browser()->tab_strip_model()->GetActiveWebContents();

content::WebContents* contents =