Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2346)

Unified Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/better_session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/better_session_restore_browsertest.cc b/chrome/browser/sessions/better_session_restore_browsertest.cc
index 96809f75183a95636db0c810b047518dcd496d5f..a75386663cb5cff0cdab169b19cfa719a1fcc940 100644
--- a/chrome/browser/sessions/better_session_restore_browsertest.cc
+++ b/chrome/browser/sessions/better_session_restore_browsertest.cc
@@ -547,7 +547,7 @@ IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest,
// which stores a session cookie.
StoreDataWithPage("session_cookies.html");
Browser* popup = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
popup->window()->Show();
Browser* new_browser = QuitBrowserAndRestore(browser(), false);
@@ -826,7 +826,7 @@ IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
SessionCookiesBrowserCloseWithPopupOpen) {
StoreDataWithPage("session_cookies.html");
Browser* popup = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
popup->window()->Show();
Browser* new_browser = QuitBrowserAndRestore(browser(), false);
NavigateAndCheckStoredData(new_browser, "session_cookies.html");
@@ -838,7 +838,7 @@ IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
SessionCookiesBrowserClosePopupLast) {
StoreDataWithPage("session_cookies.html");
Browser* popup = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
popup->window()->Show();
CloseBrowserSynchronously(browser());
Browser* new_browser = QuitBrowserAndRestore(popup, false);
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698