Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_test.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc
index 5df6a2a4c3b67e3c163fe0b41fa560a98ec4148d..c519fd0c73fef29f355c6fbf30731ded2cf846e8 100644
--- a/chrome/browser/extensions/api/tabs/tabs_test.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc
@@ -173,7 +173,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, MAYBE_GetWindow) {
// Popup.
Browser* popup_browser = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
function = new WindowsGetFunction();
function->set_extension(extension.get());
result.reset(utils::ToDictionary(
@@ -644,7 +644,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DontCreateTabInClosingPopupWindow) {
// a new tab in it. Tab should not be opened in the popup window, but in a
// tabbed browser window.
Browser* popup_browser = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
int window_id = ExtensionTabUtil::GetWindowId(popup_browser);
chrome::CloseWindow(popup_browser);
@@ -868,9 +868,10 @@ Browser* ExtensionWindowLastFocusedTest::CreateBrowserWithEmptyTab(
Browser* new_browser;
if (as_popup)
new_browser = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
else
- new_browser = new Browser(Browser::CreateParams(browser()->profile()));
+ new_browser =
+ new Browser(Browser::CreateParams(browser()->profile(), true));
AddBlankTabAndShow(new_browser);
return new_browser;
}
@@ -1255,7 +1256,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, FilteredEvents) {
" \"maxWidth\": 400, \"maxHeight\": 400}}");
Browser* browser_window =
- new Browser(Browser::CreateParams(browser()->profile()));
+ new Browser(Browser::CreateParams(browser()->profile(), true));
AddBlankTabAndShow(browser_window);
DevToolsWindow* devtools_window =

Powered by Google App Engine
This is Rietveld 408576698