chrome/browser/extensions/api/permissions/permissions_api_unittest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api_unittest.cc ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_unittest.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_unittest.cc b/chrome/browser/extensions/api/permissions/permissions_api_unittest.cc

index caa46e7e0598241ed201212573a2f80e13b8cbee..28b90107c8becf5ee667c84469d165ba072e60c7 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_unittest.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api_unittest.cc

@@ -74,7 +74,7 @@ class PermissionsAPIUnitTest : public ExtensionServiceTestWithInstall {

ExtensionServiceTestWithInstall::SetUp();

InitializeEmptyExtensionService();

browser_window_.reset(new TestBrowserWindow());

- Browser::CreateParams params(profile());

+ Browser::CreateParams params(profile(), true);

params.type = Browser::TYPE_TABBED;

params.window = browser_window_.get();

browser_.reset(new Browser(params));