chrome/browser/extensions/api/extension_action/browser_action_apitest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc ('k') | chrome/browser/extensions/api/management/management_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

index 876abcc72a4f205de1a94ac1b907498804f73956..2d57dda866e562ffd42d7201213406c8be3b8c72 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

@@ -542,7 +542,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoBasic) {

Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();

base::RunLoop().RunUntilIdle(); // Wait for profile initialization.

Browser* incognito_browser =

- new Browser(Browser::CreateParams(incognito_profile));

+ new Browser(Browser::CreateParams(incognito_profile, true));

ASSERT_EQ(0,

BrowserActionTestUtil(incognito_browser).NumberOfBrowserActions());

@@ -576,7 +576,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoSplit) {

// Open an incognito window.

Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();

Browser* incognito_browser =

- new Browser(Browser::CreateParams(incognito_profile));

+ new Browser(Browser::CreateParams(incognito_profile, true));

base::RunLoop().RunUntilIdle(); // Wait for profile initialization.

// Navigate just to have a tab in this window, otherwise wonky things happen.

OpenURLOffTheRecord(browser()->profile(), GURL("about:blank"));