chrome/browser/extensions/api/browser/browser_api.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/browser/browser_api.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/browser/browser_api.cc

diff --git a/chrome/browser/extensions/api/browser/browser_api.cc b/chrome/browser/extensions/api/browser/browser_api.cc

index 205d583b013061868a4d267784a8cd92cb1c1572..f9f133b0adba843796e12aef9fcc9588d32327cb 100644

--- a/chrome/browser/extensions/api/browser/browser_api.cc

+++ b/chrome/browser/extensions/api/browser/browser_api.cc

@@ -24,7 +24,7 @@ ExtensionFunction::ResponseAction BrowserOpenTabFunction::Run() {

std::string error;

std::unique_ptr<base::DictionaryValue> result(

- ExtensionTabUtil::OpenTab(this, options, &error));

+ ExtensionTabUtil::OpenTab(this, options, user_gesture(), &error));

if (!result)

return RespondNow(Error(error));