Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc
diff --git a/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc b/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc
index cf849b16c823d0a4bd2493f2a88775252f2daee6..e19be6e22ce3615f3954340baed29a345f2f1a25 100644
--- a/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc
+++ b/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc
@@ -33,7 +33,7 @@ class GoodiesDisplayerBrowserTest : public InProcessBrowserTest,
// Create a new browser and wait for completion.
ui_test_utils::BrowserAddedObserver browser_added_observer;
Browser* browser = new Browser(
- Browser::CreateParams(ProfileManager::GetActiveUserProfile()));
+ Browser::CreateParams(ProfileManager::GetActiveUserProfile(), true));
browser_added_observer.WaitForSingleNewBrowser();
// Set up Goodies Displayer and set fake age of device.
@@ -124,8 +124,8 @@ IN_PROC_BROWSER_TEST_P(GoodiesDisplayerBrowserTest, DisplayGoodies) {
ASSERT_EQ(1u, chrome::GetTotalBrowserCount());
// Shouldn't show Goodies tab in incognito mode.
- Browser* incognito_browser = new Browser(
- Browser::CreateParams(browser->profile()->GetOffTheRecordProfile()));
+ Browser* incognito_browser = new Browser(Browser::CreateParams(
+ browser->profile()->GetOffTheRecordProfile(), true));
ASSERT_EQ(2u, chrome::GetTotalBrowserCount());
AddBlankTabAndShow(incognito_browser);
ExpectTabCounts(incognito_browser, 1, 0);
« no previous file with comments | « chrome/browser/captive_portal/captive_portal_browsertest.cc ('k') | chrome/browser/download/download_crx_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698